[PATCH] D27590: [SimplifyCFG] In sinkLastInstruction correctly set the debug location of the "common" instruction

Fri Dec 9 04:38:57 PST 2016

rob.lougher added a comment.

In https://reviews.llvm.org/D27590#617630, @dblaikie wrote:

>

Thanks for the review!

> (just out of curiosity/confirmation - I'd like to know that test fails without the check, I'm not 100% confident on my FileCheck emulation in my head to verify that it'll catch the bug)

  $ opt -simplifycfg simplifycfg_sink_last_inst.ll -S -o - | FileCheck simplifycfg_sink_last_inst.ll 
  <stdin>:21:39: error: CHECK-NOT: string occurred!
   %sub2 = sub nsw i32 %b, %call1.sink, !dbg !11
                                        ^
  simplifycfg_sink_last_inst.ll:28:14: note: CHECK-NOT: pattern specified here
  ; CHECK-NOT: !dbg
               ^

https://reviews.llvm.org/D27590