[PATCH] D27579: [libFuzzer] Diff 19 - Automatically link with Windows library.
Zachary Turner via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 9 04:00:11 PST 2016
zturner added a comment.
I had imagined the algorithm starting from the end and looking backwards for the first separator. I can't find anything wrong, so it seems fine, but did you consider starting from the end and going backwards and decide it was more difficult and/or wouldn't work?
================
Comment at: lib/Fuzzer/FuzzerIOWindows.cpp:149
+// Returns number of characters considered if successful.
+static size_t ParseDrive(const std::string &FileName, const size_t In,
+ bool Relative = true) {
----------------
Can we use a better name than `In`? I'm not sure what it's supposed to represent. Is this more like the starting offset? If so call it `Offset` perhaps.
================
Comment at: lib/Fuzzer/FuzzerIOWindows.cpp:190
+static size_t ParseServerAndShare(const std::string &FileName, const size_t In) {
+ size_t Pos = In, Ad;
+ if (!(Ad = ParseDir(FileName, Pos)))
----------------
What is `Ad` supposed to be short for? If it means something (Address?), I would just write it out as a full word.
================
Comment at: lib/Fuzzer/FuzzerIOWindows.cpp:203
+// Returns number of characters considered if successful.
+static size_t ParseCustomString(std::string Ref, size_t In, const char* Patt) {
+ size_t Len = strlen(Patt);
----------------
should `Ref` be a const reference?
Repository:
rL LLVM
https://reviews.llvm.org/D27579
More information about the llvm-commits
mailing list