[PATCH] D27579: [libFuzzer] Diff 19 - Automatically link with Windows library.

[Zachary Turner via Phabricator via llvm-commits]

zturner added a comment.

Can you do a quick sanity check that we return similar output on Posix and Windows (i.e. run all the above tests through Linux's `DirName` function and verify that they're the same)?  Obviously slashes will be different, and things like `\\?\` syntax and UNC syntax won't apply.  But for example, but the postconditions of the function should be the same on Posix and Windows, such as if you pass a simple filenmae like `foo.txt` to the function, then your example shows we return `.`, therefore Posix should return `.` as well otherwise someone might rely on it.  Similarly, for `foo\bar\file.txt`, if we return `foo\bar`, then I would expect `/foo/bar/file.txt` on Posix would return `/foo/bar` without a trailing slash.  (This is another argument for not relying on the Windows function in shlwapi I suppose, since we should try to match the postconditions as closely as possible.


Repository:
  rL LLVM

https://reviews.llvm.org/D27579