[PATCH] D27602: [PGO] Fix insane counts due to nonreturn calls

[David Li via Phabricator via llvm-commits]

davidxl added inline comments.


================
Comment at: lib/Transforms/Instrumentation/PGOInstrumentation.cpp:888
+          uint64_t Total = 0;
+          uint64_t OutSum = sumEdgeCount(Count->OutEdges);
+          if (Count->CountValue > OutSum)
----------------
Can you explain how this happens?  For non return calls, should an edge be added from the call's BB to exit bb?


================
Comment at: test/Transforms/PGOProfile/noreturncall.ll:9
+declare i32 @bar0(i32)
+declare void @exit(i32)
+
----------------
exit is not used .


https://reviews.llvm.org/D27602