[PATCH] D27595: COFF: Support both /lldmap and /lldmap:<file>

[Hans Wennborg via Phabricator via llvm-commits]

hans marked an inline comment as done.
hans added a comment.

In https://reviews.llvm.org/D27595#617733, @ruiu wrote:

> IIRC, the reason why I chose a different name than /map is because the output format is different. If some build system is using /map, it is likely that it reads a result file afterwards using a script, so I chose to fail early. In that sense, I think keeping the different name still makes sense.


Sounds reasonable.



================
Comment at: COFF/Driver.cpp:775
   // to help debugging.
-  if (auto *Arg = Args.getLastArg(OPT_lldmap)) {
+  std::string MapFile = getMapFile(Args.getLastArg(OPT_lldmap, OPT_lldmap_file),
+                                   Config->OutputFile);
----------------
ruiu wrote:
> Pass `Args` and call `getLastArg` in getMapFile. Since Config is a global variable, you don't need to pass it to the function.
Thanks! That's nicer.


https://reviews.llvm.org/D27595