[PATCH] D27587: Add "X / 1.0" to SimplifyFDivInst

[Zia Ansari via Phabricator via llvm-commits]

zansari updated this revision to Diff 80814.
zansari added a comment.

That was timely and convenient, Sanjay.. Thanks :)

Also, thanks David.

Removed my overly complicated test, and "FIXME'ed" Sanjay's test to catch X/1.0.


https://reviews.llvm.org/D27587

Files:
  lib/Analysis/InstructionSimplify.cpp
  test/Transforms/InstSimplify/floating-point-arithmetic.ll


Index: lib/Analysis/InstructionSimplify.cpp
===================================================================
--- lib/Analysis/InstructionSimplify.cpp
+++ lib/Analysis/InstructionSimplify.cpp
@@ -1127,6 +1127,10 @@
   if (match(Op1, m_Undef()))
     return Op1;
 
+  // X / 1.0 -> X
+  if (match(Op1, m_FPOne()))
+    return Op0;
+
   // 0 / X -> 0
   // Requires that NaNs are off (X could be zero) and signed zeroes are
   // ignored (X could be positive or negative, so the output sign is unknown).
@@ -4093,6 +4097,8 @@
     return SimplifyFSubInst(LHS, RHS, FMF, Q, MaxRecurse);
   case Instruction::FMul:
     return SimplifyFMulInst(LHS, RHS, FMF, Q, MaxRecurse);
+  case Instruction::FDiv:
+    return SimplifyFDivInst(LHS, RHS, FMF, Q, MaxRecurse);
   default:
     return SimplifyBinOp(Opcode, LHS, RHS, Q, MaxRecurse);
   }
Index: test/Transforms/InstSimplify/floating-point-arithmetic.ll
===================================================================
--- test/Transforms/InstSimplify/floating-point-arithmetic.ll
+++ test/Transforms/InstSimplify/floating-point-arithmetic.ll
@@ -62,12 +62,10 @@
   ret double %b
 }
 
-; FIXME:
 ; fdiv X, 1.0 ==> X
 define float @fdiv_x_1(float %a) {
 ; CHECK-LABEL: @fdiv_x_1(
-; CHECK-NEXT:    [[RET:%.*]] = fdiv float %a, 1.000000e+00
-; CHECK-NEXT:    ret float [[RET]]
+; CHECK-NEXT:    ret float %a
 ;
   %ret = fdiv float %a, 1.0
   ret float %ret


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D27587.80814.patch
Type: text/x-patch
Size: 1407 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161208/be489bda/attachment.bin>