[PATCH] D27579: [libFuzzer] Diff 19 - Automatically link with Windows library.

[Zachary Turner via llvm-commits]

std::regex isn't implemented until GCC 4.9, and LLVM needs to work with GCC
4.8.  So unfortunately std::regex is out of the question.

We can't straight up use llvm support because libfuzzer can't take a
dependency on llvm, so it would have to be a re-write using LLVM support as
a model for the algorithm.  It doesn't look very complicated to me.

That aside, from talks with kcc@ it seems that one of the important
considerations with libfuzzer is to take as few dependencies as possible on
external code, which was my motivation for not linking in shlapi.  This
will also cause the application being fuzzed to link in shlapi as well, and
it seems possible (albeit remote) to introduce behavioral changes.

So I think we should strive for minimal dependencies, especially on
heavyweight user libraries like shlwapi.  If something is genuinely
difficult to implement then it's a different story, but here we're talking
about something only slightly more complicated than looking for the last
backslash and chopping off everything that comes after.

On Thu, Dec 8, 2016 at 11:29 AM Marcos Pividori via Phabricator <
reviews at reviews.llvm.org> wrote:

> mpividori added a comment.
>
> It's based on the documentation for Naming Files, Paths, and Namespaces
> in:
> https://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).aspx
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D27579
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161208/22eb0144/attachment.html>