[PATCH] D26224: NewGVN

[Hal Finkel via llvm-commits]

----- Original Message -----

> From: "Daniel Berlin via llvm-commits" <llvm-commits at lists.llvm.org>
> To: reviews+D26224+public+3b1fe8d104b1c17a at reviews.llvm.org
> Cc: "llvm-commits" <llvm-commits at lists.llvm.org>, "Jack Howarth"
> <howarth.mailing.lists at gmail.com>, "filcab+llvm phabricator"
> <filcab+llvm.phabricator at gmail.com>, "Davide Italiano"
> <dccitaliano at gmail.com>, deadalnix+llvmreview at gmail.com
> Sent: Thursday, December 8, 2016 12:41:58 PM
> Subject: Re: [PATCH] D26224: NewGVN

> So, i kinda don't feel comfortable reviewing this, but if nobody else
> steps up i'll take a stab at some point.
I'll also look at it. 

> My reasoning is:

> 1. I wrote it, which means, outside of style issues, i already
> thought it was not horrible.
> 2. Having worked on it for years at this point, i understand it very
> very well, which means that the best hope of making it
> understandable to others is to have others read it and point out
> things they don't get that i would gloss over :)
> 3. I'm on paternity leave, having had a newborn on saturday :)
Congratulations :) 

-Hal 

> On Mon, Dec 5, 2016 at 6:57 AM, Davide Italiano via Phabricator <
> reviews at reviews.llvm.org > wrote:

> > davide added a comment.
> 

> > Monday morning ping.
> 
> > I would like to get the first cut in-tree soon (let's say, this
> > week
> > or the next) so we can iterate in-tree.
> 

> > https://reviews.llvm.org/D26224
> 

> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits

-- 

Hal Finkel 
Lead, Compiler Technology and Programming Languages 
Leadership Computing Facility 
Argonne National Laboratory 
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161208/649c2298/attachment.html>