[lld] r289025 - [ELF][MIPS] Make _gp, _gp_disp, __gnu_local_gp global symbols

[Simon Atanasyan via llvm-commits]

On Thu, Dec 8, 2016 at 5:00 PM, Rafael Avila de Espindola
<rafael.espindola at gmail.com> wrote:
> Simon Atanasyan via llvm-commits <llvm-commits at lists.llvm.org> writes:
>
>> Author: atanasyan
>> Date: Thu Dec  8 00:19:47 2016
>> New Revision: 289025
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=289025&view=rev
>> Log:
>> [ELF][MIPS] Make _gp, _gp_disp, __gnu_local_gp global symbols
>
>
> The commit message says global
>
>> -    if (Symbol *S = addOptionalRegular("__gnu_local_gp", In<ELFT>::MipsGot, 0))
>> -      ElfSym<ELFT>::MipsLocalGp = cast<DefinedRegular<ELFT>>(S->body());
>> +    if (Symtab<ELFT>::X->find("__gnu_local_gp"))
>> +      ElfSym<ELFT>::MipsLocalGp =
>> +          Symtab<ELFT>::X->addAbsolute("__gnu_local_gp", STV_HIDDEN, STB_LOCAL);
>
> But here you use STB_LOCAL. Was the commit message supposed to say
> absolute?

Absolute, of course. Stupid mistake.

-- 
Simon Atanasyan