[PATCH] D27390: [sanitizer] Use architecture/slice information when symbolizing fat Mach-O files on Darwin
Filipe Cabecinhas via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 8 05:27:32 PST 2016
filcab added inline comments.
================
Comment at: lib/sanitizer_common/sanitizer_symbolizer_libcdep.cc:340
}
return false;
}
----------------
kubabrecka wrote:
> filcab wrote:
> > Maybe `return buf && ParseSymbolizePCOutput(buf, stack);` instead of the `if`?
> > Same thing below.
> I think that would be less readable.
OK with me.
Repository:
rL LLVM
https://reviews.llvm.org/D27390
More information about the llvm-commits
mailing list