[PATCH] D27556: LTO: Hash the parts of the LTO configuration that affect code generation.

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson added a comment.

Thanks for fixing this. Looks pretty good but a couple of questions.



================
Comment at: llvm/include/llvm/CodeGen/CommandFlags.h:235
 
+cl::opt<bool> RelaxELFRelocations(
+    "relax-elf-relocations",
----------------
Why is this new option being added here?


================
Comment at: llvm/lib/LTO/LTO.cpp:85
+  // FIXME: Hash more of Options. For now all clients initialize Options from
+  // command-line flags (which is unsupported in production), but may set
+  // RelaxELFRelocations.
----------------
I don't understand the comment about all clients initializing Options from command line flags, but it being unsupported in production.


https://reviews.llvm.org/D27556