[PATCH] D27295: Remove existing file in a separate thread asynchronously.
Rafael Avila de Espindola via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 7 18:29:13 PST 2016
Rui Ueyama <ruiu at google.com> writes:
> I agree that that's the right way of doing it in the sense that it
> atomically replaces old file with a new result file. There's no chance that
> we removed a file but we didn't create a new result. However, I guess that
> wouldn't solve the issue that I was trying to address with this patch.
> Maybe the last rename takes 0.25 seconds?
With your current patch we do a rename before starting the thread, so
maybe the rename is fast?
But I was really surprised by unlink being slow, so we really have to
measure to be sure.
Cheers,
Rafael
More information about the llvm-commits
mailing list