[PATCH] D27326: Make a DWARF generator so we can unit test DWARF APIs with gtest.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

Thanks, I think this looks good now!
Please be sure to test this with '-DLLVM_TARGETS_TO_BUILD=ARM' to make sure this works even if the X86 target isn't present before committing.



================
Comment at: lib/CodeGen/DwarfGenerator.h:52
+
+//------------------------------------------------------------------------------
+/// A DWARF debug information entry class used to generate DWARF DIEs.
----------------
I would remove this line.


================
Comment at: lib/CodeGen/DwarfGenerator.h:59
+/// by calling dwarfgen::DIE::addChild(...) and using the returned DIE object.
+//------------------------------------------------------------------------------
+class DIE {
----------------
please remove this line, I think it conflicts with Doxygen's parser.


https://reviews.llvm.org/D27326