[PATCH] D27551: [DebugInfo] Add regression test for __fp16, float, and double constants.

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 7 15:34:26 PST 2016


probinson added inline comments.


================
Comment at: test/DebugInfo/Generic/static-const-fp.ll:38
+
+attributes #0 = { nounwind uwtable "correctly-rounded-divide-sqrt-fp-math"="false" "disable-tail-calls"="false" "less-precise-fpmad"="false" "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf" "no-infs-fp-math"="false" "no-jump-tables"="false" "no-nans-fp-math"="false" "no-signed-zeros-fp-math"="false" "no-trapping-math"="false" "stack-protector-buffer-size"="8" "target-cpu"="x86-64" "target-features"="+fxsr,+mmx,+sse,+sse2,+x87" "unsafe-fp-math"="false" "use-soft-float"="false" }
+attributes #1 = { nounwind readnone }
----------------
Generally we remove all the unnecessary attributes, rather than just take the raw -emit-llvm output.


================
Comment at: test/DebugInfo/Generic/static-const-fp.ll:78
+; CHECK: DW_TAG_variable
+; CHECK-NOT: {{^0}}
+; CHECK: DW_AT_name {{.*}} "hVal"
----------------
To verify that the next attribute is part of the same DIE we usually do:
```
CHECK-NOT: {{DW_TAG|NULL}}
```
which shows it's not in a child and not in a DIE from a higher nesting level.


https://reviews.llvm.org/D27551





More information about the llvm-commits mailing list