[PATCH] D26348: Allow convergent attribute for function arguments

[Justin Lebar via Phabricator via llvm-commits]

jlebar accepted this revision.
jlebar added a comment.
This revision is now accepted and ready to land.

Since we seem to be getting close to agreement on the langref wording, I went ahead and looked at the rest of the code.  Just one minor comment, otherwise it looks good to me.  I guess I have a broader question of, did you audit in order to make sure that these are the only places where we need to handle specifically convergent args?  Do you need a reviewer to check that?



================
Comment at: lib/Transforms/Utils/SimplifyCFG.cpp:1443
+    // because there may be divergence in the argument that was removed by the
+    // control flow conditions for those blocks.
+    if (isa<CallInst>(I0) || isa<InvokeInst>(I0)) {
----------------
I don't understand the "because" clause here; can we rephrase?


https://reviews.llvm.org/D26348