[PATCH] D27378: [asan] Teach asan_symbolize.py to use :arch with atos and llvm-symbolizer on Darwin

[Filipe Cabecinhas via Phabricator via llvm-commits]

filcab added a comment.

Please add an `if force_system_symbolizer: assert(allow_system_symbolizer)` or similar, to do a sanity check.



================
Comment at: lib/asan/scripts/asan_symbolize.py:444
     stack_trace_line_format = (
-        '^( *#([0-9]+) *)(0x[0-9a-f]+) *\((.*)\+(0x[0-9a-f]+)\)')
+        '^( *#([0-9]+) *)(0x[0-9a-f]+) *\(([^:]*)(:(.*))?\+(0x[0-9a-f]+)\)')
     match = re.match(stack_trace_line_format, line)
----------------
Isn't `:` a valid filename character on most Linux fs?


Repository:
  rL LLVM

https://reviews.llvm.org/D27378