[PATCH] D27534: [BDCE] Skip metadata while replacing uses

[Hal Finkel via Phabricator via llvm-commits]

hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Transforms/Scalar/BDCE.cpp:42-45
     // If the instruction has side effects and no non-dbg uses,
     // BDCE should skip it.
     if (I.mayHaveSideEffects() && I.use_empty())
       continue;
----------------
davide wrote:
> majnemer wrote:
> > I think we can remove this special case now.
> Hal suggested to keep it as a micro-optimization. I'm fine either way.
I don't feel strongly about it. It does make sense as a micrp-optimization because it will avoid us computing known bits on an instruction where that will never help us.



https://reviews.llvm.org/D27534