[PATCH] D27327: [InstCombine] Fix to switch narrowing

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 7 13:10:40 PST 2016


hans added inline comments.


================
Comment at: lib/Transforms/InstCombine/InstructionCombining.cpp:2276
-      Constant *LHS = CaseVal;
-      if (TruncCond) {
-        LHS = LeadingKnownZeros
----------------
What happened to this part?


================
Comment at: test/Transforms/InstCombine/narrow-switch.ll:108
 ; ALL-LABEL: @trunc64to59(
-; ALL:         switch i59
-; ALL-NEXT:    i59 0, label %sw.bb1
-; ALL-NEXT:    i59 18717182647723699, label %sw.bb2
+; ALL:         switch i61
+; ALL-NEXT:    i61 0, label %sw.bb1
----------------
Why does this need to be i61 now, and should the test be renamed to reflect that?


https://reviews.llvm.org/D27327





More information about the llvm-commits mailing list