[PATCH] D27524: [ELF][MIPS] Make _gp, _gp_disp, __gnu_local_gp global symbols

Simon Atanasyan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 7 13:07:48 PST 2016


atanasyan added a comment.

>> Doesn't _gp_disp represents offset between _gp and .got? I'm not sure what you mean by "a function" in the above description.
> 
> Your question gives me a good idea. Maybe it is better to add a new expression R_MIPS_GP_DISP for this case. So we will not mix these specific relocations with regular R_PC relocations and will be able to write checking more clear.

Not so good as expected. The code is not reduced and we have to put new R_MIPS_GP_DISP  expression type in too many place. So I prefer my initial patch.


Repository:
  rL LLVM

https://reviews.llvm.org/D27524





More information about the llvm-commits mailing list