[PATCH] D27390: [sanitizer] Use architecture/slice information when symbolizing fat Mach-O files on Darwin

[Filipe Cabecinhas via Phabricator via llvm-commits]

filcab added a comment.

This incremental change looks good. I'd rather let @kcc chime in in case he'd rather have it done another way, though.
But in the end, I'm not sure if this applies elsewhere, since most OS we support don't really have fat binaries.



================
Comment at: lib/sanitizer_common/sanitizer_common.h:684
+}
+
 const uptr kModuleUUIDSize = 16;
----------------
I'm guessing you added this to two reviews so you commit either first but you'll merge the definitions later, right?


================
Comment at: lib/sanitizer_common/sanitizer_symbolizer_libcdep.cc:340
   }
   return false;
 }
----------------
Maybe `return buf && ParseSymbolizePCOutput(buf, stack);` instead of the `if`?
Same thing below.


================
Comment at: test/asan/TestCases/Darwin/haswell-symbolication.cc:51
+// REQUIRES: x86_64h
+// REQUIRES: shell
+
----------------
Why?


Repository:
  rL LLVM

https://reviews.llvm.org/D27390