[PATCH] D27463: Change llvm::Regex to expose a fallible constructor.

[David L. Jones via Phabricator via llvm-commits]

dlj added a comment.

In https://reviews.llvm.org/D27463#616162, @dlj wrote:

> In https://reviews.llvm.org/D27463#615399, @vsk wrote:
>
> > If the goal is to make sure regex errors are checked, we could avoid a substantial amount of API churn by asserting 'no error' in every method in Regex.
>
>
> That's the end goal I'm aiming for in the current change, but by a different route: for regexes compiled from static char[] constants, I'm just letting the Expected<Regex> propagate the error.


err, rather, *not* propagate the error -- and crash with asserts enabled.


https://reviews.llvm.org/D27463