[PATCH] D27512: Refactor clang's ParseHelper into Support (llvm part)

[Hans Wennborg via Phabricator via llvm-commits]

hans added a comment.

> This moves clang's ParseHelper class (currently used to parse comments for the -verify option) into the Support library so that it can be used elsewhere in LLVM.

What use do you have in mind?

I'd suggest renaming the title of the patch from "Refactor clang's ParseHelper into Support " to something like "Move clang's ParseHelper ..." since you're not so much refactoring it as moving it.

ParseHelper is currently in an anonmymous namespace inside VerifyDiagnosticConsumer, that is, it's an implementation detail of that class. The name makes sense in that context: it helps with the parsing in that file, but does the name make sense externally?



================
Comment at: include/llvm/Support/ParseHelper.h:53
+
+  const char * const Begin; // beginning of expected content
+  const char * const End;   // end of expected content (1-past)
----------------
Does it make sense to have all of these as public members?


Repository:
  rL LLVM

https://reviews.llvm.org/D27512