[PATCH] D27238: [libFuzzer] Diff 7 - Improve Signal Handler interface.

Kostya Serebryany via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 7 11:13:41 PST 2016


kcc added inline comments.


================
Comment at: lib/Fuzzer/FuzzerUtilWindows.cpp:30
 
-LONG WINAPI SEGVHandler(PEXCEPTION_POINTERS ExceptionInfo) {
+static struct {
+   bool HandleAbrt = false;
----------------
mpividori wrote:
> kcc wrote:
> > Why do you need a copy of the flags? 
> @kcc,
> We can't save a reference to Options, because we don't know when it will be destroyed. The ExceptionHandler() function must access to Handler option the entire life of the program.
you can rely on this FuzzingOptions object to be live throughout the process. 


Repository:
  rL LLVM

https://reviews.llvm.org/D27238





More information about the llvm-commits mailing list