[llvm] r288871 - [LVI] Simplify obfuscated code
Philip Reames via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 7 10:03:44 PST 2016
Already fixed.
Pnilip
On 12/06/2016 09:37 PM, Mike Aizatsky wrote:
> Philip,
>
> This breaks multiple builds:
>
> E.g.:
>
> http://lab.llvm.org:8011/builders/sanitizer-ppc64be-linux/builds/627/steps/bootstrap%20clang/logs/stdio
>
> /home/buildbots/ppc64be-sanitizer/sanitizer-ppc64be/build/llvm/lib/Analysis/LazyValueInfo.cpp:189:14:
> error: unused variable 'changed' [-Werror,-Wunused-variable] bool
> changed = Range != NewR; ^
>
>
> On Tue, Dec 6, 2016 at 4:38 PM Philip Reames via llvm-commits
> <llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>> wrote:
>
> Author: reames
> Date: Tue Dec 6 18:28:28 2016
> New Revision: 288871
>
> URL: http://llvm.org/viewvc/llvm-project?rev=288871&view=rev
> Log:
> [LVI] Simplify obfuscated code
>
> It doesn't matter why something is overdefined if it is...
>
>
> Modified:
> llvm/trunk/lib/Analysis/LazyValueInfo.cpp
>
> Modified: llvm/trunk/lib/Analysis/LazyValueInfo.cpp
> URL:
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/LazyValueInfo.cpp?rev=288871&r1=288870&r2=288871&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Analysis/LazyValueInfo.cpp (original)
> +++ llvm/trunk/lib/Analysis/LazyValueInfo.cpp Tue Dec 6 18:28:28 2016
> @@ -224,29 +224,15 @@ public:
> return false;
> return markOverdefined();
> }
> -
> - if (RHS.isNotConstant()) {
> - if (Val == RHS.Val)
> - return markOverdefined();
> - return markOverdefined();
> - }
> -
> return markOverdefined();
> }
>
> if (isNotConstant()) {
> - if (RHS.isConstant()) {
> - if (Val == RHS.Val)
> - return markOverdefined();
> - return markOverdefined();
> - }
> -
> if (RHS.isNotConstant()) {
> if (Val == RHS.Val)
> return false;
> return markOverdefined();
> }
> -
> return markOverdefined();
> }
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org <mailto:llvm-commits at lists.llvm.org>
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits
>
> --
> Mike
> Sent from phone
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161207/7559a536/attachment.html>
More information about the llvm-commits
mailing list