[PATCH] D27469: [LoopVersioning] Check if exit block dominates runtime check block.
Adam Nemet via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 7 09:09:34 PST 2016
anemet added a comment.
In https://reviews.llvm.org/D27469#615851, @hfinkel wrote:
> In https://reviews.llvm.org/D27469#614831, @anemet wrote:
>
> > LGTM. @hfinkel, is there a better way to handle infinite loops like this?
>
>
> I agree with Eli; we generally avoid this kind of situation by only handling loops that can be in loop-simplify form.
Yeah, same here, thank Eli! I even tried -loop-simplify on the test case before first replying but I failed to notice that it created an exit block that *no longer* dominated the loop header. So I wrongly concluded that loop-simplify wouldn't help here.
https://reviews.llvm.org/D27469
More information about the llvm-commits
mailing list