[PATCH] D27506: [ELF] - Print absolute file name in errors when possible.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: ELF/InputFiles.cpp:95
+  std::string Ret = Info.FileName + ":" + std::to_string(Info.Line);
+#ifdef LLVM_ON_WIN32
+  // Converts path to use unix path separators so error message is
----------------
Add a blank line before #ifdef.


================
Comment at: test/ELF/Inputs/undef-debug.s:1
-.file 1 "undef-debug.s"
+.file 1 "folder/undef-debug.s"
 .loc 1 3
----------------
nit: "folder" as a term is probably windows-ish too? probably "dir" or something.


https://reviews.llvm.org/D27506