[PATCH] D27522: [X86] Don't allow floating-point return types when SSE[12] is disabled

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 7 08:32:15 PST 2016


RKSimon added a comment.

In https://reviews.llvm.org/D27522#615894, @thegameg wrote:

> In https://reviews.llvm.org/D27522#615861, @RKSimon wrote:
>
> > Please can you add the context to the diff?
>
>
> I'm sorry, I'm not sure I understand what you mean by "context". Should I include the comments in the `.patch`?  Should I add the comments added in the revision as comments in the code?


http://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-web-interface

Use `svn diff --diff-cmd=diff -x -U999999` to create patches that include surrounding context so its easier to work out how the diff fits into the rest of the source.

Cheers, Simon


https://reviews.llvm.org/D27522





More information about the llvm-commits mailing list