[PATCH] D27524: [ELF][MIPS] Make _gp, _gp_disp, __gnu_local_gp global symbols

Simon Atanasyan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 7 08:07:08 PST 2016


atanasyan created this revision.
atanasyan added a reviewer: ruiu.
atanasyan added subscribers: llvm-commits, meadori.
atanasyan set the repository for this revision to rL LLVM.
atanasyan added a project: lld.
Herald added a subscriber: sdardis.

These MIPS specific symbols should be global because in general they can have an arbitrary value. By default this value is a fixed offset from .got section.

                                                                            

This patch adds more checks to the mips-gp-local.s test case but marks it as XFAIL because LLD does not allow redefinition of absolute symbols value by a linker script. This should be fixed by https://reviews.llvm.org/D27276.


Repository:
  rL LLVM

https://reviews.llvm.org/D27524

Files:
  ELF/Relocations.cpp
  ELF/SymbolTable.cpp
  ELF/SymbolTable.h
  ELF/Symbols.h
  ELF/Target.cpp
  ELF/Writer.cpp
  test/ELF/basic-mips.s
  test/ELF/mips-64-disp.s
  test/ELF/mips-64-got.s
  test/ELF/mips-64-gprel-so.s
  test/ELF/mips-64-rels.s
  test/ELF/mips-got-relocs.s
  test/ELF/mips-gp-disp.s
  test/ELF/mips-gp-ext.s
  test/ELF/mips-gp-local.s
  test/ELF/mips-gprel32-relocs-gp0.s
  test/ELF/mips-gprel32-relocs.s
  test/ELF/mips-hilo-gp-disp.s
  test/ELF/mips-n32-rels.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D27524.80598.patch
Type: text/x-patch
Size: 16779 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161207/b549f1c8/attachment.bin>


More information about the llvm-commits mailing list