[PATCH] D27338: [globalisel] Tablegen-erate current Register Bank Information

Daniel Sanders via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 7 07:15:03 PST 2016


dsanders updated this revision to Diff 80593.
dsanders marked 2 inline comments as done.
dsanders added a comment.

Updated following review:

- Use more descriptive macros when #include'ing tablegen-erated files
- Rename visitor function
- assert Begin!=End and simplify related for-loop.
- Remove redundant .str()'s
- getEnumeratorName() no longer returns a reference to an implicitly constructed local StringRef. This showed up when removing the .str()'s
- last -> first


https://reviews.llvm.org/D27338

Files:
  include/llvm/Target/GlobalISel/RegisterBank.td
  include/llvm/Target/Target.td
  lib/Target/AArch64/AArch64.td
  lib/Target/AArch64/AArch64GenRegisterBankInfo.def
  lib/Target/AArch64/AArch64RegisterBankInfo.cpp
  lib/Target/AArch64/AArch64RegisterBankInfo.h
  lib/Target/AArch64/AArch64RegisterBanks.td
  lib/Target/AArch64/CMakeLists.txt
  utils/TableGen/CMakeLists.txt
  utils/TableGen/RegisterBankEmitter.cpp
  utils/TableGen/TableGen.cpp
  utils/TableGen/TableGenBackends.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D27338.80593.patch
Type: text/x-patch
Size: 26498 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161207/a6dbcf30/attachment.bin>


More information about the llvm-commits mailing list