[PATCH] D27506: [ELF] - Print absolute file name in errors when possible.
Rafael Avila de Espindola via llvm-commits
llvm-commits at lists.llvm.org
Wed Dec 7 06:48:41 PST 2016
George Rimar via Phabricator <reviews at reviews.llvm.org> writes:
> - return Info.FileName + ":" + std::to_string(Info.Line);
> + std::string Ret = Info.FileName + ":" + std::to_string(Info.Line);
> +#ifdef LLVM_ON_WIN32
> + // Converts path to use unix path separators so error message is
> + // consistent between platforms.
> + std::replace(Ret.begin(), Ret.end(), '\\', '/');
> +#endif
Don't we have an utility function to do this? I am sure we make the same
transformation on cpio files.
Cheers,
Rafael
More information about the llvm-commits
mailing list