[PATCH] D26547: [PPC] add intrinsics mapping to the extractuw/insertw instructions

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 7 02:24:14 PST 2016


nemanjai added inline comments.


================
Comment at: lib/Target/PowerPC/PPCInstrVSX.td:2218
 
+  // Extra patterns expanding to vector Extract Word/Insert Word
+  def : Pat<(v4i32 (int_ppc_vsx_xxinsertw v4i32:$A, v2i64:$B, imm:$IMM)),
----------------
This does not require another revision of the patch, but on the commit, please change the location of these in the file. Namely, we usually put anonymous patterns at the end of the named (instruction) definitions. When you do so, please make sure that you specify the correct Predicates and AddedComplexity as needed.


Repository:
  rL LLVM

https://reviews.llvm.org/D26547





More information about the llvm-commits mailing list