[PATCH] D27243: Initial work on the XRay Graph tool.

[Alexis Shaw via Phabricator via llvm-commits]

varno marked 5 inline comments as done.
varno added inline comments.


================
Comment at: tools/llvm-xray/xray-graph.h:115-124
+  /// Calculates latency statistics for each edge and stores the data in the
+  /// Graph
+  void calculateEdgeStatistics(void);
+
+  ///Calculates latency statistics for each vertex and stores the data in the
+  /// Graph
+  void calculateVertexStatistics(void);
----------------
dberris wrote:
> varno wrote:
> > dberris wrote:
> > > Can this not happen incrementally, as we're adding the records, or on demand when we export? i.e. why do they need to be public functions?
> > Not really, all the records need to be added before we calculate the statistics. And I was wanting the statistics calculated to do graph transformations later (before output).
> Sure, but why aren't these just implementation details of the exportGraphAsDOT(...) function?
I suppose that right now they could be, but I have plans that require them to be run before exportGraphAsDOT


https://reviews.llvm.org/D27243