[PATCH] D27463: Change llvm::Regex to expose a fallible constructor.

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 6 18:34:33 PST 2016


vsk added a comment.

If the goal is to make sure regex errors are checked, we could avoid a substantial amount of API churn by asserting 'no error' in every method in Regex.

If you also want to make match() const, we'll need to get rid of the isValid method and the error field. That probably means adding an optional out-param to the Regex constructor for error descriptions.


https://reviews.llvm.org/D27463





More information about the llvm-commits mailing list