[PATCH] D27238: [libFuzzer] Diff 7 - Improve Signal Handler interface.

[Kostya Serebryany via Phabricator via llvm-commits]

kcc added a comment.

Your patch does make sense, but OTOH, indirection and encapsulation are a very powerful tool  -- don't overuse them. 
I still suggest that you add bool flags to FuzzerOptions and use them in FuzzerUtilWindows.cpp



================
Comment at: lib/Fuzzer/FuzzerUtilPosix.cpp:58
+  if (Opt.sigint_cb)
+    SetSigaction(SIGINT, [](int,siginfo_t*,void*) {HandlerOpt.sigint_cb();});
+  if (Opt.sigterm_cb)
----------------
Don't use lambda in such cases because you will see the lambda in the error messages and that will make the messages longer. 


Repository:
  rL LLVM

https://reviews.llvm.org/D27238