[PATCH] D27355: [WebAssembly] Add wasm support for llvm-readobj

[Derek Schuff via Phabricator via llvm-commits]

dschuff accepted this revision.
dschuff added a reviewer: dschuff.
dschuff added inline comments.
This revision is now accepted and ready to land.


================
Comment at: tools/llvm-readobj/WasmDumper.cpp:57
+    ListScope Group(W, "Sections");
+    for (const SectionRef &Section : Obj->sections()) {
+      const wasm::WasmSection *WasmSec = Obj->getWasmSection(Section);
----------------
dschuff wrote:
> I wonder if we should have a field in the output for the name as well. Output for user sections wouldn't be very interesting without it, and it would be consistent with other formats which have names for every section. Obviously only user sections have interesting names that are different from their types, but it wouldn't hurt to also print "TABLE" or "EXPORT" or whatever for the standard sections as well. 
Come to think of it, we should do that in llvm-objdump as well, so maybe that can just be a separate change.


https://reviews.llvm.org/D27355