[PATCH] D27238: [libFuzzer] Diff 7 - Improve Signal Handler interface.

[Zachary Turner via llvm-commits]

rnk@, in the current patch we do install multiple exception handlers.  But
I agree it would be preferable if we could install only 1.  The question
is: How do you get the struct of bools into the exception handler?  Do you
make it a global?  Kinda ugly, but if there's a nice solution it would be
great.

On Tue, Dec 6, 2016 at 2:04 PM Reid Kleckner via Phabricator <
reviews at reviews.llvm.org> wrote:

> rnk added a comment.
>
> In https://reviews.llvm.org/D27238#614137, @kcc wrote:
>
> > Dunno. As is the change increases the code size w/o solving any problem.
>
>
> The problem, as I see it, is that SetSigFooHandler pattern exposes the
> wrong cross-platform API. On Windows, we will install exactly one exception
> handler, switch on the exception code, and then decide whether to catch it
> based on the user's options.
>
> Would you be OK with this direction if we had a struct of bools instead of
> a struct of callbacks?
>
>
> Repository:
>   rL LLVM
>
> https://reviews.llvm.org/D27238
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161206/27d2d82c/attachment.html>