[PATCH] D26232: [XRay][compiler-rt] XRay Buffer Queue

[Serge Rogatch via Phabricator via llvm-commits]

rSerge added inline comments.


================
Comment at: compiler-rt/trunk/lib/xray/tests/unit/buffer_queue_test.cc:28
+  BufferQueue::Buffer Buf;
+  ASSERT_FALSE(Buffers.getBuffer(Buf));
+  ASSERT_NE(nullptr, Buf.Buffer);
----------------
Here and in the other places `ASSERT_NE(Buffers.getBuffer(Buf), 0)` would give more information in case the test fails: the error code would get into the report produced by gtest.
Forcing it to boolean producess less informative report:
```
Value of: Buffers.getBuffer(Buf)
Actual: true
Expected: false
```
http://lab.llvm.org:8011/builders/clang-native-aarch64-full/builds/100/steps/ninja%20check%202/logs/FAIL%3A%20XRay-Unit%3A%3ABufferQueueTest.GetAndRelease


Repository:
  rL LLVM

https://reviews.llvm.org/D26232