[PATCH] D27050: [X86] Add explicit regparm flag for X86-32 calling convention.

[Reid Kleckner via Phabricator via llvm-commits]

rnk added a comment.

You touched stdcall, and that reminded me of -mrtd, which has the same problem as -mregparm=: calls to library functions generated by LLVM aren't handled correctly.

Does anybody have any objections to doing this with module flags? They seem like the right kind of thing here for communicating global settings to the backend, and they have the nice property that mismatches get diagnosed during LTO. If you use function attributes as you've done in this patch, it's still possible to LTO a non-regparm TU with a regparm TU and get weird results.


https://reviews.llvm.org/D27050