[PATCH] D27466: [SLP] Fix sign-extends for type-shrinking

[Matthew Simpson via Phabricator via llvm-commits]

mssimpso added inline comments.


================
Comment at: test/Transforms/SLPVectorizer/X86/minimum-sizes.ll:12
+; CHECK-LABEL: @PR31243
+; CHECK-NOT: sext i8 {{.*}} to i32
+;
----------------
mkuper wrote:
> mssimpso wrote:
> > mkuper wrote:
> > > Can you make the test more explicit by checking the extends we actually want to appear?
> > Sure. I'll upload a new version.
> Shouldn't we also have a test where we increase the bit-width because we don't know the sign bit?
> I'm a bit surprised this didn't affect any of our existing tests.
That's a good idea - I'll add another test for the sext case.


https://reviews.llvm.org/D27466