[PATCH] D27458: [ELF] - Teach LLD to recognize PT_OPENBSD_BOOTDATA

Tue Dec 6 09:45:45 PST 2016

grimar added a comment.

In https://reviews.llvm.org/D27458#614665, @ruiu wrote:

> LGTM. Let's do cleanup in a followup patch.

Thanks. By the way, after looking closer, openbsd-randomize.s (PT_OPENBSD_RANDOMIZE) and openbsd-wxneeded.s (PT_OPENBSD_WXNEEDED) are a bit different form this.
Both of them involve additional logic in LLD.

PT_OPENBSD_WXNEEDED relative to -z wxneeded,
PT_OPENBSD_RANDOMIZE is generated when we have ".openbsd.randomdata" section.
I would probably not combine their testcases.

May be we should just rename this testcase to openbsd-common-phdrs.s and use for all OpenBSD program headers that do not require any special logic ?

https://reviews.llvm.org/D27458