[PATCH] D27458: [ELF] - Teach LLD to recognize PT_OPENBSD_BOOTDATA

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 6 08:29:47 PST 2016


ruiu added inline comments.


================
Comment at: test/ELF/linkerscript/openbsd-bootdata.s:2-4
+# RUN: echo "PHDRS { text PT_LOAD FILEHDR PHDRS; boot PT_OPENBSD_BOOTDATA; } \
+# RUN:       SECTIONS { . = SIZEOF_HEADERS; \
+# RUN:         .text : { *(.text) } \
----------------
Why did you need .text?

Also, please do not use line continuations (\) in echo. It makes output messages hard to read when this test fails.


================
Comment at: test/ELF/linkerscript/openbsd-bootdata.s:11-20
+# CHECK-NEXT:   Offset: 0x74
+# CHECK-NEXT:   VirtualAddress: 0x74
+# CHECK-NEXT:   PhysicalAddress: 0x74
+# CHECK-NEXT:   FileSize: 8
+# CHECK-NEXT:   MemSize: 8
+# CHECK-NEXT:   Flags [ (0x4)
+# CHECK-NEXT:     PF_R (0x4)
----------------
Remove these lines because we are not interested in testing them.


https://reviews.llvm.org/D27458





More information about the llvm-commits mailing list