[PATCH] D26743: Expandload and Compressing store - documentation update

[Elena Demikhovsky via Phabricator via llvm-commits]

delena marked 8 inline comments as done.
delena added inline comments.


================
Comment at: docs/LangRef.rst:11882
+
+The first operand is the base pointer for the load. The second operand, mask, is a vector of boolean values with the same number of elements as the return type. The third is a pass-through value that is used to fill the masked-off lanes of the result. The return type and the type of the '``passthru``' operand are the same vector types.
+
----------------
Ayal wrote:
> Explain about the type of the first operand.
"The underlying type of the pointer is a scalar type of vector element" - is this description clear?


================
Comment at: docs/LangRef.rst:11903
+    ; The number of loaded elements is equal to the number of 'true' elements in the mask.
+    %Tmp = call <8 x double> @llvm.masked.expandload.v8f64(double* %Bptr, <8 x i1> %mask, <8 x double> undef)
+    ; Store the result in A
----------------
Ayal wrote:
> %Bptr should have type <8 x double>*, right?
No, a pointer to scalar.


================
Comment at: docs/LangRef.rst:11922-11923
+
+      declare void @llvm.masked.compressstore.v8i32  (<8  x i32>   <value>, i32*   <ptr>, <8  x i1> <mask>)
+      declare void @llvm.masked.compressstore.v16f32 (<16 x float> <value>, float* <ptr>, <16 x i1> <mask>)
+
----------------
Ayal wrote:
> ptr should have pointer-to-vector types.
I defined them as pointers to scalar values.


Repository:
  rL LLVM

https://reviews.llvm.org/D26743