[PATCH] D27386: build: add support for standalone lld build

[Chris Bieneman via Phabricator via llvm-commits]

beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.

One minor nit below, and a question. Otherwise LGTM!



================
Comment at: CMakeLists.txt:16
+                  RESULT_VARIABLE HAD_ERROR
+                  OUTPUT_VARIABLE LLVM_CONFIG_OUTPUT
+                  OUTPUT_STRIP_TRAILING_WHITESPACE)
----------------
Since you're only outputting one field now you should be able to just write the result directly into `OBJ_ROOT`. Then you can get rid of the string processing below.


================
Comment at: CMakeLists.txt:44
+
+  set(LLVM_RUNTIME_OUTPUT_INTDIR ${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin)
+  find_program(LLVM_TABLEGEN_EXE "llvm-tblgen" ${LLVM_TOOLS_BINARY_DIR} NO_DEFAULT_PATH)
----------------
Do you need to define `LLVM_LIBRARY_OUTPUT_INTDIR` or `LLVM_SHLIB_OUTPUT_INTDIR`?


Repository:
  rL LLVM

https://reviews.llvm.org/D27386