[PATCH] D27442: [llgo] Update to use the latest IR attribute bindings

[Meador Inge via Phabricator via llvm-commits]

meadori added inline comments.


================
Comment at: irgen/attribute.go:150
+		kind := llvm.AttributeKindID(strings.ToLower(field))
+		result.AttrKinds = append(result.AttrKinds, kind)
 	}
----------------
pcc wrote:
> We probably don't want to allow arbitrary attributes here. (In fact, I would be happy to see this feature removed entirely; it is untested and exposes too many LLVM specifics.)
Agreed.  Okay if I constrain the attribute application for now and remove the feature in a follow-on commit?


https://reviews.llvm.org/D27442