[PATCH] D27028: Add intrinsics for constrained floating point operations
Andy Kaylor via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 5 17:39:30 PST 2016
andrew.w.kaylor updated this revision to Diff 80354.
andrew.w.kaylor added a comment.
Fixed typos and style issues.
Added FIXME comments as requested.
I have opened two Bugzilla reports.
One to add FP environment register modeling:
https://llvm.org/bugs/show_bug.cgi?id=31284
One to address denormal handling:
https://llvm.org/bugs/show_bug.cgi?id=31285
I'd like to talk more about the denormal handling apart from this review. I'm not certain that rolling it into these intrinsics is the correct solution. It might be, and I'd be happy to do that if we agree that's the best approach. It seems to me as though it has certain similarities to the fast math flags as well, so I'd like to talk about that relationship a bit.
Repository:
rL LLVM
https://reviews.llvm.org/D27028
Files:
docs/LangRef.rst
include/llvm/ADT/StringSwitch.h
include/llvm/CodeGen/ISDOpcodes.h
include/llvm/CodeGen/SelectionDAGISel.h
include/llvm/IR/IntrinsicInst.h
include/llvm/IR/Intrinsics.td
lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h
lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
lib/IR/IntrinsicInst.cpp
lib/IR/Verifier.cpp
test/CodeGen/X86/fp-intrinsics.ll
test/Feature/fp-intrinsics.ll
test/Verifier/fp-intrinsics.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D27028.80354.patch
Type: text/x-patch
Size: 37371 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161206/be713d30/attachment.bin>
More information about the llvm-commits
mailing list