[PATCH] D27421: [XRay][AArch64] Attempt to fix unstable test XRay-aarch64-linux::patching-unpatching.cc

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 5 16:26:57 PST 2016


dberris added a comment.

In https://reviews.llvm.org/D27421#613951, @rSerge wrote:

> By the way, if I scroll the current page up, I can see field "Commits", and there https://reviews.llvm.org/rL288729 is listed. So it just didn't do it the way it does for your commits, with stating "Closed by commit" and then the commit number.


Cool -- right, I was looking for that "Closed by commit" message, because it just looked like you closed the revision, without an indication that it indeed was committed.

It might be something silly like, if that message 'Differential Revision: https://...' didn't have a newline character in the end then Phabricator didn't quite parse it properly.

Anyway, something to try for another patch. :)


https://reviews.llvm.org/D27421





More information about the llvm-commits mailing list