[PATCH] D27343: [framelowering] Improve tracking of first CS pop instruction.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked 3 inline comments as done.
fhahn added inline comments.


================
Comment at: test/CodeGen/X86/frame-lowering-debug-intrinsic.ll:4
+; RUN: llc  -mtriple=x86_64-unknown-unknown < %s | FileCheck %s
+
+define double @noDebug(double %a) {
----------------
MatzeB wrote:
> The test seems bigger than necessary. Some things that could be simplified:
> 
> - Remove the `; preds =` comments
> - Simplify float constants to 0x0? Or use integer math in the first place?
> - Do you need the calls to fmod, fabs?
> - The nounwind, readnone attributes should not be necessary
> - I don't know much about debuginfo, but if there is a way to reduce the amount of metadata at the end...
I've reduced the test case quite a bit. AFAIK the debug data in the test case is the minimum required.


https://reviews.llvm.org/D27343