[PATCH] D27028: Add intrinsics for constrained floating point operations

[Andy Kaylor via Phabricator via llvm-commits]

andrew.w.kaylor added inline comments.


================
Comment at: lib/IR/IntrinsicInst.cpp:106
+    return rmDynamic;
+  else if (RoundingArg.equals("LLVM_ROUND_TONEAREST"))
+    return rmToNearest;
----------------
craig.topper wrote:
> Don't use 'else' after an 'if' containing a 'return' per coding standards.
I can make that change.  What I wanted to convey here is that this is effectively a switch statement with no uncovered cases.  I suppose since there is no way to get the compiler to warn if that ever changes there is no particular benefit in doing it this way.


Repository:
  rL LLVM

https://reviews.llvm.org/D27028