[PATCH] D27399: [tsan] Unify the stack trace render format between TSan and ASan

[Kuba (Brecka) Mracek via Phabricator via llvm-commits]

kubabrecka removed rL LLVM as the repository for this revision.
kubabrecka updated this revision to Diff 80287.
kubabrecka added a comment.

Okay, how about just adding the raw PC to the beginning of the line, just like ASan does?

Raw PC is useful when you're in the debugger.  The address is valid in the live process and you can easily ask the debugger to tell you where the PC belongs, what instruction is it, get disassembly around.  That doesn't work that well with module name + offset.


https://reviews.llvm.org/D27399

Files:
  lib/tsan/rtl/tsan_flags.cc


Index: lib/tsan/rtl/tsan_flags.cc
===================================================================
--- lib/tsan/rtl/tsan_flags.cc
+++ lib/tsan/rtl/tsan_flags.cc
@@ -69,7 +69,7 @@
       cf.detect_deadlocks = true;
     }
     cf.print_suppressions = false;
-    cf.stack_trace_format = "    #%n %f %S %M";
+    cf.stack_trace_format = "    #%n %p %f %S %M";
     cf.exitcode = 66;
     cf.intercept_tls_get_addr = true;
     OverrideCommonFlags(cf);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D27399.80287.patch
Type: text/x-patch
Size: 453 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20161205/93741798/attachment.bin>