[PATCH] D27309: builtins: Add ARM Thumb1 implementation for uidiv and uidivmod

Weiming Zhao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 5 09:47:39 PST 2016


weimingz added a comment.

In https://reviews.llvm.org/D27309#613384, @rengolin wrote:

> In https://reviews.llvm.org/D27309#613371, @compnerd wrote:
>
> > Thanks for the various revisions.  I don't think that the tests for the built-ins are run on the bots, so please do run them locally again before committing.
>
>
> Wait, aren't them executed when "make check-all" is used on compiler-rt?


The default CMake file uses -march=armv7, so the "thumb1" path is not tested by check-all.
 Locally, I changed the CMake to let udivsi3.S to be used for armv6m.


https://reviews.llvm.org/D27309





More information about the llvm-commits mailing list